I'm a big fan of both the Schaller dual button guys and DiMarzio's Cliplock ones. Only problem I had with Cliplocks before is the strap was always too long, but the JP signature solved that.
Also, on thicker straps, the nut tends to get loose over time so there's a bit of maintenance involved.If you discover and try Schallers, be aware that the "horseshoe" on the strap side can rotate 180 degrees, leaving the guitar in a vulnerable position. I definitely damaged a guitar once thanks to Schaller strap locks. I still use them, I just check the position every single time.