Thank you for the link. I will update the post to mention that.
Furthermore, "dumb" autocorrelation methods like this are mostly useless for determining "pitch". They may find a frequency but are extremely prone to octave errors. A guitar note often has a 2nd harmonic that has more energy than the fundamental. Play an A at the 2nd fret on the G string. The 2nd harmonic is usually 10-20 dB greater than the fundamental. This method will not find the fundamental.
One of the biggest mistakes an engineer can make is thinking they know more than they do. This happens in any discipline but some engineers seem especially prone to this. Humility is a virtue. I'd probably hire someone like you if you were looking for a job as you seem motivated. But you need to understand your limitations. No matter how much you think you know, someone out there knows more about a particular subject than you do.
https://patents.google.com/patent/US4429609A/en?oq=4429609
At 44.1 kHz sample rate this is around 11 us. The period of a sine wave at 440 Hz is 22 ms. 11 us of error may not seem like a lot but it's actually 5 cents of error. This is unacceptably high for most applications. The error gets progressively worse as you go up in frequency. The error at 820 Hz will be ten times worse than the error at 82 Hz. The basic problem is that the autocorrelation is quantized. This isn't a problem if you are using a significant number of bits to represent the signal as you can interpolate the autocorrelation (which is what we do) but with a one-bit representation you cannot interpolate.
Still working on the pitch shifting and Cliff also wants to redo the chorus block.Why not V 12.08 release? beta 4 ??
I'm waiting for 12.08 release
Well as I wrote multiple times already, my concern is NOT about the EQ curve, but about the artificial sounding modulation and slight flanging effect in the reverb decay which I never ever heard in any real spring reverb. But everyone else here seems to think that a real spring reverb show the same artifacts, so I'll keep my mouth shut on this subject.I wasn't referring to that but to the hi cut in the axe fx reverb.
That's the main difference I hear in your samples: less highs in Space Designer.
It's not about shutting up when there's issues not being confirmed by others. You may want to post in the "bugs" section.Well as I wrote multiple times already, my concern is NOT about the EQ curve, but about the artificial sounding modulation and slight flanging effect in the reverb decay which I never ever heard in any real spring reverb. But everyone else here seems to think that a real spring reverb show the same artifacts, so I'll keep my mouth shut on this subject.
The only "help" I got so far is the proposal to change the EQ curve which I know is not the problem for me. And I don't think this is a "bug" (quite obviously other people here really like how the Spring Reverb sounds) so I don't see the point in opening a thread in the bugs section for this.It's not about shutting up when there's issues not being confirmed by others. You may want to post in the "bugs" section.
I've seen others including Cliff himself confirm at first not happening on their end and then later on confirming there is something going on.
Also ...it may be an issue just on your end and all the great Fractal elite folks here are all about helping you figure it out if that's the case.
I was just asking if you tried that before dismissing it, a more aggressive high-cut could help mask that modulation you don't like, besides making it sound closer to Sound DesignerWell as I wrote multiple times already, my concern is NOT about the EQ curve, but about the artificial sounding modulation and slight flanging effect in the reverb decay which I never ever heard in any real spring reverb. But everyone else here seems to think that a real spring reverb show the same artifacts, so I'll keep my mouth shut on this subject.
I like turtles.Thanks for sharing.
Unlikely. There will probably be another beta before a release version.
I've been slaving away all week on the pitch shifter. It's very, very good now. I'm now using a wavelet approach for the pitch detection. This provides even faster detection than before and increases the low frequency detection by an octave which makes shifting chords smoother.
I still want to do an overhaul of the Chorus using the techniques that were used in the Flanger. I also have some ideas on reverb (although the reverb is pretty great already).
Is there any advantage with the current algorithm vs the new version you are working on? The single note tracking in beta 3 is pretty amazing!
It's turtles all the way down.I like turtles.
It's turtles all the way down.